chore: add CI env variable configurations #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch adds some environment variables to configure *all* CI jobs. In particular, we: - disable incremental compilation - increase the number of retries for network requests in `cargo` and `rustup` - emit shortened backtraces from panics This config was blatantly stolen from linkerd/linkerd2-proxy#7137. :) Incremental compilation is useful as part of an edit-build-test-edit cycle, as it lets the compiler avoid recompiling code that hasn't changed. However, on CI, we're not making small edits; we're almost always building the entire project from scratch. Thus, incremental compilation on CI actually introduces *additional* overhead to support making future builds faster...but no future builds will ever occur in any given CI environment. See https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow for details. Increasing retries for network requests should help reduce flakiness a bit.
davidbarsky
approved these changes
Oct 22, 2021
hawkw
added a commit
that referenced
this pull request
Oct 22, 2021
This branch adds some environment variables to configure *all* CI jobs. In particular, we: - disable incremental compilation - increase the number of retries for network requests in `cargo` and `rustup` - emit shortened backtraces from panics This config was blatantly stolen from linkerd/linkerd2-proxy#7137. :) Incremental compilation is useful as part of an edit-build-test-edit cycle, as it lets the compiler avoid recompiling code that hasn't changed. However, on CI, we're not making small edits; we're almost always building the entire project from scratch. Thus, incremental compilation on CI actually introduces *additional* overhead to support making future builds faster...but no future builds will ever occur in any given CI environment. See https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow for details. Increasing retries for network requests should help reduce flakiness a bit.
hawkw
added a commit
that referenced
this pull request
Oct 22, 2021
This branch adds some environment variables to configure *all* CI jobs. In particular, we: - disable incremental compilation - increase the number of retries for network requests in `cargo` and `rustup` - emit shortened backtraces from panics This config was blatantly stolen from linkerd/linkerd2-proxy#7137. :) Incremental compilation is useful as part of an edit-build-test-edit cycle, as it lets the compiler avoid recompiling code that hasn't changed. However, on CI, we're not making small edits; we're almost always building the entire project from scratch. Thus, incremental compilation on CI actually introduces *additional* overhead to support making future builds faster...but no future builds will ever occur in any given CI environment. See https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow for details. Increasing retries for network requests should help reduce flakiness a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds some environment variables to configure all CI jobs.
In particular, we:
cargoandrustupThis config was blatantly stolen from linkerd/linkerd2-proxy#7137. :)
Incremental compilation is useful as part of an edit-build-test-edit
cycle, as it lets the compiler avoid recompiling code that hasn't
changed. However, on CI, we're not making small edits; we're almost
always building the entire project from scratch. Thus, incremental
compilation on CI actually introduces additional overhead to support
making future builds faster...but no future builds will ever occur in
any given CI environment.
See https://matklad.github.io/2021/09/04/fast-rust-builds.html#ci-workflow
for details.
Increasing retries for network requests should help reduce flakiness a
bit.