diff --git a/examples/examples/fmt-compact.rs b/examples/examples/fmt-compact.rs index a4899ce379..14cdd8a45f 100644 --- a/examples/examples/fmt-compact.rs +++ b/examples/examples/fmt-compact.rs @@ -7,7 +7,7 @@ fn main() { .compact() // enable everything .with_max_level(tracing::Level::TRACE) - // sets this to be the default, global collector for this application. + // sets this to be the default, global subscriber for this application. .init(); let number_of_yaks = 3; diff --git a/examples/examples/fmt-source-locations.rs b/examples/examples/fmt-source-locations.rs index 799ebb17d5..b4b05b3027 100644 --- a/examples/examples/fmt-source-locations.rs +++ b/examples/examples/fmt-source-locations.rs @@ -14,7 +14,7 @@ fn main() { .with_line_number(true) // disable targets .with_target(false) - // sets this to be the default, global collector for this application. + // sets this to be the default, global subscriber for this application. .init(); let number_of_yaks = 3; diff --git a/tracing-core/src/dispatcher.rs b/tracing-core/src/dispatcher.rs index 32632abdc5..de02afb790 100644 --- a/tracing-core/src/dispatcher.rs +++ b/tracing-core/src/dispatcher.rs @@ -518,8 +518,8 @@ impl Dispatch { } } - /// Registers a new callsite with this collector, returning whether or not - /// the collector is interested in being notified about the callsite. + /// Registers a new callsite with this subscriber, returning whether or not + /// the subscriber is interested in being notified about the callsite. /// /// This calls the [`register_callsite`] function on the [`Subscriber`] /// that this `Dispatch` forwards to. diff --git a/tracing-subscriber/src/filter/env/builder.rs b/tracing-subscriber/src/filter/env/builder.rs index c814707e6c..8572647412 100644 --- a/tracing-subscriber/src/filter/env/builder.rs +++ b/tracing-subscriber/src/filter/env/builder.rs @@ -212,7 +212,7 @@ impl Builder { #[cfg(feature = "nu_ansi_term")] use nu_ansi_term::{Color, Style}; // NOTE: We can't use a configured `MakeWriter` because the EnvFilter - // has no knowledge of any underlying subscriber or collector, which + // has no knowledge of any underlying subscriber or subscriber, which // may or may not use a `MakeWriter`. let warn = |msg: &str| { #[cfg(not(feature = "nu_ansi_term"))] diff --git a/tracing-subscriber/src/filter/layer_filters/mod.rs b/tracing-subscriber/src/filter/layer_filters/mod.rs index a8b3ef7a1d..69736fafd4 100644 --- a/tracing-subscriber/src/filter/layer_filters/mod.rs +++ b/tracing-subscriber/src/filter/layer_filters/mod.rs @@ -694,7 +694,7 @@ impl Filtered { /// # } /// ``` /// - /// [subscriber]: Subscribe + /// [`Layer`]: crate::layer::Layer pub fn inner_mut(&mut self) -> &mut L { &mut self.layer } @@ -706,8 +706,8 @@ where F: layer::Filter + 'static, L: Layer, { - fn on_register_dispatch(&self, collector: &Dispatch) { - self.layer.on_register_dispatch(collector); + fn on_register_dispatch(&self, subscriber: &Dispatch) { + self.layer.on_register_dispatch(subscriber); } fn on_layer(&mut self, subscriber: &mut S) { @@ -1190,7 +1190,7 @@ impl FilterState { } } - /// Run a second filtering pass, e.g. for Subscribe::event_enabled. + /// Run a second filtering pass, e.g. for Layer::event_enabled. fn and(&self, filter: FilterId, f: impl FnOnce() -> bool) -> bool { let map = self.enabled.get(); let enabled = map.is_enabled(filter) && f(); diff --git a/tracing-subscriber/src/fmt/time/time_crate.rs b/tracing-subscriber/src/fmt/time/time_crate.rs index 60d57fd0bc..4883db418d 100644 --- a/tracing-subscriber/src/fmt/time/time_crate.rs +++ b/tracing-subscriber/src/fmt/time/time_crate.rs @@ -76,9 +76,9 @@ impl LocalTime { /// ``` /// use tracing_subscriber::fmt::{self, time}; /// - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(time::LocalTime::rfc_3339()); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// [local time]: time::OffsetDateTime::now_local @@ -130,9 +130,9 @@ impl LocalTime { /// use time::macros::format_description; /// /// let timer = LocalTime::new(format_description!("[hour]:[minute]:[second]")); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using [`time::format_description::parse`]: @@ -143,9 +143,9 @@ impl LocalTime { /// let time_format = time::format_description::parse("[hour]:[minute]:[second]") /// .expect("format string should be valid!"); /// let timer = LocalTime::new(time_format); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using the [`format_description!`] macro requires enabling the `time` @@ -158,9 +158,9 @@ impl LocalTime { /// use tracing_subscriber::fmt::{self, time::LocalTime}; /// /// let timer = LocalTime::new(time::format_description::well_known::Rfc3339); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// [local time]: time::OffsetDateTime::now_local() @@ -207,9 +207,9 @@ impl UtcTime { /// ``` /// use tracing_subscriber::fmt::{self, time}; /// - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(time::UtcTime::rfc_3339()); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// [local time]: time::OffsetDateTime::now_utc @@ -247,9 +247,9 @@ impl UtcTime { /// use time::macros::format_description; /// /// let timer = UtcTime::new(format_description!("[hour]:[minute]:[second]")); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using the [`format_description!`] macro requires enabling the `time` @@ -263,9 +263,9 @@ impl UtcTime { /// let time_format = time::format_description::parse("[hour]:[minute]:[second]") /// .expect("format string should be valid!"); /// let timer = UtcTime::new(time_format); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using a [well-known format][well-known formats] (this is equivalent to @@ -275,9 +275,9 @@ impl UtcTime { /// use tracing_subscriber::fmt::{self, time::UtcTime}; /// /// let timer = UtcTime::new(time::format_description::well_known::Rfc3339); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// [UTC time]: time::OffsetDateTime::now_utc() @@ -326,9 +326,9 @@ impl OffsetTime { /// ``` /// use tracing_subscriber::fmt::{self, time}; /// - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(time::OffsetTime::local_rfc_3339().expect("could not get local offset!")); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using `OffsetTime` with Tokio: @@ -398,9 +398,9 @@ impl OffsetTime { /// /// let offset = UtcOffset::current_local_offset().expect("should get local offset!"); /// let timer = OffsetTime::new(offset, format_description!("[hour]:[minute]:[second]")); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using [`time::format_description::parse`]: @@ -413,9 +413,9 @@ impl OffsetTime { /// let time_format = time::format_description::parse("[hour]:[minute]:[second]") /// .expect("format string should be valid!"); /// let timer = OffsetTime::new(offset, time_format); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// Using the [`format_description!`] macro requires enabling the `time` @@ -430,9 +430,9 @@ impl OffsetTime { /// /// let offset = UtcOffset::current_local_offset().expect("should get local offset!"); /// let timer = OffsetTime::new(offset, time::format_description::well_known::Rfc3339); - /// let collector = tracing_subscriber::fmt() + /// let subscriber = tracing_subscriber::fmt() /// .with_timer(timer); - /// # drop(collector); + /// # drop(subscriber); /// ``` /// /// [`time` crate]: time diff --git a/tracing-subscriber/src/layer/layered.rs b/tracing-subscriber/src/layer/layered.rs index f09c58c97c..e276514986 100644 --- a/tracing-subscriber/src/layer/layered.rs +++ b/tracing-subscriber/src/layer/layered.rs @@ -470,7 +470,7 @@ where return Interest::sometimes(); } - // otherwise, allow the inner subscriber or collector to weigh in. + // otherwise, allow the inner subscriber or subscriber to weigh in. inner } diff --git a/tracing-subscriber/src/layer/mod.rs b/tracing-subscriber/src/layer/mod.rs index 9dcfcc927c..296de5ef48 100644 --- a/tracing-subscriber/src/layer/mod.rs +++ b/tracing-subscriber/src/layer/mod.rs @@ -750,8 +750,8 @@ where /// [`WeakDispatch`]: tracing_core::dispatcher::WeakDispatch /// [upgraded]: tracing_core::dispatcher::WeakDispatch::upgrade /// [`Subscriber`]: tracing_core::Subscriber - fn on_register_dispatch(&self, collector: &Dispatch) { - let _ = collector; + fn on_register_dispatch(&self, subscriber: &Dispatch) { + let _ = subscriber; } /// Performs late initialization when attaching a `Layer` to a