Fix leak in LocalSet #3978
Merged
Fix leak in LocalSet #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Makes sense to me. I asked @hawkw to take a quick look as well.
hawkw
approved these changes
Jul 21, 2021
| use std::task::Poll; | ||
|
|
||
| #[test] | ||
| fn wake_during_shutdown() { |
There was a problem hiding this comment.
it would be nice to have a comment explaining what the failure modes of this test are, for future reference? not a blocker though.
Comment on lines
+564
to
+567
| .queue | ||
| .lock() | ||
| .as_mut() | ||
| .and_then(|queue| queue.pop_front()) |
There was a problem hiding this comment.
TIOLI: it seems like queue.lock().as_mut().and_then(|queue| queue.pop_front()) could be worth making a method on Shared, but 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task is woken during shutdown, it is possible for it to remain in the shared queue after shutting down the
LocalSet, which would be a leak due to a ref-count cycle. This PR provides a fix. TheEnable loom testcommit was pushed first without the fix to show that the test really fails.