Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutex in JoinError #3959

Merged
merged 3 commits into from Jul 16, 2021
Merged

Remove mutex in JoinError #3959

merged 3 commits into from Jul 16, 2021

Conversation

Darksonn
Copy link
Contributor

This PR removes a mutex from the JoinError type. The mutex was originally added in #1888 to make the JoinError type Sync, but we can achieve the same with the technique outlined in sync_wrapper.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jul 14, 2021
@Darksonn Darksonn merged commit aef2d64 into master Jul 16, 2021
@Darksonn Darksonn deleted the join-error-mutex branch July 16, 2021 07:50
sthagen added a commit to sthagen/tokio-rs-tokio that referenced this pull request Jul 16, 2021
task: remove mutex in JoinError (tokio-rs#3959)
@Darksonn Darksonn mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants