Explicit impl Clone for tx to avoid T: Clone #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 23, 2019
ghost
deleted a comment from
jonhoo
added a commit
to jonhoo/tokio
that referenced
this pull request
Jan 23, 2019
Following from tokio-rs#865, this PR removes `#[derive(Debug)]` on `mpsc` sender and receiver types in favor of explicit `impl fmt::Debug` blocks that don't have a `T: fmt::Debug` bound.
jonhoo
added a commit
that referenced
this pull request
Jan 23, 2019
Following from #865, this PR removes `#[derive(Debug)]` on `mpsc` sender and receiver types in favor of explicit `impl fmt::Debug` blocks that don't have a `T: fmt::Debug` bound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[derive(Clone)]on a typestruct Foo<T>adds an impl that requires thatT: Clone:which is unfortunate in the case of senders, because we don't want to require that the items being sent are
Clonefor the channel sender to beClone. This PR adds an explicitimpl Clonefor the bounded and unbounded sender types which does not have theT: Clonebound.Note that this is also an issue with
#[derive(Debug)], but that one is harder to work around aschan::Txalso has#[derive(Debug)], as doeschan::Chan, so we'd have to add explicit impls for all of them to make progress.