Reset the delay of the queue in case an item that expires sooner than… #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
previously approved these changes
Jan 24, 2019
tokio-timer/src/delay_queue.rs
Outdated
| } else { false }; | ||
|
|
||
| if should_clear_delay { | ||
| self.delay = None; |
There was a problem hiding this comment.
Instead of clearing it, should the delay be reset to when?
carllerche
reviewed
Jan 24, 2019
… the last inserted is put into the queue.
carllerche
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This should fix #854
Solution
The solution is to simply check whether the expiration of the item to be inserted is sooner than the one which has been polled last. In that case we simply clear the
delay