Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasm32-wasip1 target #6484

Open
Darksonn opened this issue Apr 14, 2024 · 0 comments
Open

Use wasm32-wasip1 target #6484

Darksonn opened this issue Apr 14, 2024 · 0 comments
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. T-wasm Topic: Web Assembly

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Apr 14, 2024

Tokio currently only supports preview 1 of wasi (see #6323 on preview 2 support), and Rust is renaming the wasi target to wasm32-wasip1 in the 1.78 release of Rust.

Once Rust releases 1.78 in May 2024, we should update our wasi support to use the new target name. This fix does not need to be backported to LTS releases, since wasi support is an unstable feature.

Tokio's wasi support is unstable, so it does not need to respect Tokio's msrv. This means that it is okay that this change breaks unstable wasi support on older rustc versions. However, ordinary wasm is stable, so that should not break on older Rust versions. Please see our documentation for details on wasm support in Tokio.

@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. A-tokio Area: The main tokio crate T-wasm Topic: Web Assembly labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. T-wasm Topic: Web Assembly
Projects
None yet
Development

No branches or pull requests

1 participant