Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl std::io::BufRead on SyncIoBridge<T> if T: AsyncBufRead + Unpin #5265

Merged
merged 1 commit into from Dec 5, 2022
Merged

Impl std::io::BufRead on SyncIoBridge<T> if T: AsyncBufRead + Unpin #5265

merged 1 commit into from Dec 5, 2022

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Dec 5, 2022

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Motivation

Since SyncIoBridge<T> implements std::io::Read if T: AsyncRead + Unpin, it will be nature to assume that it will also implement std::io::BufRead if T: AsyncBufRead + Unpin.

@NobodyXu
Impl std::io::BufRead on SyncIoBridge<T> if `T: AsyncBufRead + Un…
d7d6494 
…pin`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-io Module: tokio/io labels Dec 5, 2022
Darksonn
Darksonn approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit a1316cd into tokio-rs:master Dec 5, 2022
@NobodyXu NobodyXu deleted the impl-BufRead-on-SyncIoBridge branch December 5, 2022 10:06
@Darksonn Darksonn mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @Darksonn