Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compilation on master #5190

Merged
merged 1 commit into from Nov 13, 2022
Merged

chore: fix compilation on master #5190

merged 1 commit into from Nov 13, 2022

Conversation

Darksonn
Copy link
Contributor

Master fails with the following warning on wasm:

error: unused import: `wasm_bindgen_test::wasm_bindgen_test as test`
 --> tokio/tests/sync_mpsc_weak.rs:6:5
  |
6 | use wasm_bindgen_test::wasm_bindgen_test as test;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

This is due to a PR that got merged by auto-merge even though it doesn't pass CI.

I fixed this by using #[test] for the non-async tests.

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Nov 13, 2022
@Darksonn Darksonn enabled auto-merge (squash) November 13, 2022 13:16
@Darksonn Darksonn merged commit 01f0193 into master Nov 13, 2022
@Darksonn Darksonn deleted the alice/fix-master-5189 branch November 13, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants