rt: update MultiThread to use its own Handle #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the equivalent as #5023, but for the MultiThread scheduler. This patch updates `MultiThread` to use `Arc<Handle>` for all of its cross-thread needs instead of `Arc<Shared>`. The effect of this change is that the multi-thread scheduler only has a single `Arc` type, which includes the driver handles, keeping all "shared state" together.
carllerche
added
C-maintenance
Noah-Kennedy
approved these changes
Sep 17, 2022
dbischof90
pushed a commit
to dbischof90/tokio
that referenced
this pull request
Oct 1, 2022
This is the equivalent as tokio-rs#5023, but for the MultiThread scheduler. This patch updates `MultiThread` to use `Arc<Handle>` for all of its cross-thread needs instead of `Arc<Shared>`. The effect of this change is that the multi-thread scheduler only has a single `Arc` type, which includes the driver handles, keeping all "shared state" together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of #5023, but for the MultiThread scheduler. This patch updates
MultiThreadto useArc<Handle>for all of its cross-thread needs instead ofArc<Shared>.The effect of this change is that the multi-thread scheduler only has a single
Arctype, which includes the driver handles, keeping all "shared state" together.