Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: fix will_wake usage in Notify #4751

Merged
merged 1 commit into from Jun 6, 2022

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jun 5, 2022

This fixes a bug introduced by #4747.

The will_wake function is really tricky :(

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jun 5, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jun 5, 2022
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@Darksonn Darksonn merged commit c728016 into tokio-rs:master Jun 6, 2022
@Darksonn Darksonn deleted the alice/fix-notify-will-wake branch June 6, 2022 07:40
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | patch | `1.19.1` -> `1.19.2` |
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dev-dependencies | patch | `1.19.1` -> `1.19.2` |

---

### Release Notes

<details>
<summary>tokio-rs/tokio</summary>

### [`v1.19.2`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.19.2)

[Compare Source](tokio-rs/tokio@tokio-1.19.1...tokio-1.19.2)

##### 1.19.2 (June 6, 2022)

This release fixes another bug in `Notified::enable`. ([#&#8203;4751])

[#&#8203;4751]: tokio-rs/tokio#4751

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1398
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants