Replace non-binding if let statements
#4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found some `if let` statements that don't actually bind any variables. This can make it somewhat confusing as to whether the pattern is binding the value or being matched against. Switching to `matches!` and equality comparisons allow these to be removed.
Darksonn
reviewed
Jun 2, 2022
Darksonn
reviewed
Jun 2, 2022
tokio/src/sync/notify.rs
Outdated
| if let Some(NotificationType::OneWaiter) = unsafe { (*waiter.get()).notified } { | ||
| if matches!(unsafe { (*waiter.get()).notified }, Some(NotificationType::OneWaiter)) { |
There was a problem hiding this comment.
There's a rustfmt warning here.
Darksonn
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found some
if letstatements that don't actually bind any variables. This can make it somewhat confusing as to whether the pattern is binding the value or being matched against (note that irrefutableif letpatterns are flagged by clippy).Solution
Switching to
matches!and equality comparisons allow these to be removed.