Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare tokio-util 0.6.10 #4691

Merged
merged 3 commits into from
May 14, 2022
Merged

Prepare tokio-util 0.6.10 #4691

merged 3 commits into from
May 14, 2022

Conversation

Darksonn
Copy link
Contributor

0.6.10 (May 14, 2021)

This is a backport for a memory leak in CancellationToken. (#4652)

@Darksonn Darksonn added the A-tokio-util Area: The tokio-util crate label May 14, 2022
@hawkw
Copy link
Member

hawkw commented May 14, 2022

looks like CI is failing because... the version of Tokio on this commit produces a warning on the latest compiler: https://github.com/tokio-rs/tokio/runs/6435358613?check_suite_focus=true 🙃

i'm not really sure what's the best way to handle this — it shouldn't block the tokio-util release, but it's annoying that we'll have to update a past tokio to get CI to pass...

@hawkw
Copy link
Member

hawkw commented May 14, 2022

it would be nice if there was a way to disable -D warnings on CI but only for backports, but actually implementing this probably requires a bunch of annoying GitHub Actions wrangling...

@Darksonn
Copy link
Contributor Author

Since this wont be merged with a squash, I will need a force push to squash these CI fix attempts before merging, but for now I'll just push to experiment.

hawkw
hawkw approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just changing the CI configs for the backport seems like a fine solution tbh

@hawkw
Copy link
Member

hawkw commented May 14, 2022

ugh, i have no memory of what the CircleCI build was for...https://app.circleci.com/pipelines/github/tokio-rs/tokio/657/workflows/93a890e9-15f5-4ba8-a3ae-3e604bb107bd/jobs/646

@Darksonn Darksonn added the R-loom Run loom tests on this PR label May 14, 2022
@github-actions github-actions bot removed the R-loom Run loom tests on this PR label May 14, 2022
@Darksonn Darksonn added the R-loom Run loom tests on this PR label May 14, 2022
@Darksonn Darksonn mentioned this pull request May 14, 2022
Merged
@github-actions github-actions bot removed the R-loom Run loom tests on this PR label May 14, 2022
@Darksonn Darksonn changed the title Prepare tokio util 0.6.10 Prepare tokio-util 0.6.10 May 14, 2022
@Darksonn Darksonn added the R-loom Run loom tests on this PR label May 14, 2022
renancloudwalk
renancloudwalk approved these changes May 14, 2022
View reviewed changes
Copy link

@renancloudwalk renancloudwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement towards safety 👍

.circleci/config.yml Show resolved Hide resolved
tokio-util/src/sync/cancellation_token.rs Show resolved Hide resolved
@github-actions github-actions bot removed the R-loom Run loom tests on this PR label May 14, 2022
@Darksonn Darksonn added the R-loom Run loom tests on this PR label May 14, 2022
Darksonn added a commit that referenced this pull request May 14, 2022
@Darksonn
Revert "chore: disable warnings in old CI (#4691)"
cdb132d 
This reverts commit b24df49 so we can
merge the CHANGELOG changes in #4691 into master.
@Darksonn Darksonn merged commit 2659adf into tokio-util-0.6.x May 14, 2022
@Darksonn Darksonn deleted the prepare-tokio-util-0.6.10 branch May 14, 2022 20:19
@Darksonn Darksonn mentioned this pull request May 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@renancloudwalk renancloudwalk renancloudwalk approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Darksonn @hawkw @renancloudwalk @Finomnis