Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unix abstract sockets #4610

Open
hexfusion opened this issue Apr 9, 2022 · 7 comments
Open

Support for unix abstract sockets #4610

hexfusion opened this issue Apr 9, 2022 · 7 comments
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net

Comments

@hexfusion
Copy link

Feature Request

Rust added abstract namespace support recently[1] and adding support for tokio would open up support for tonic[2]. Thanks in advance for your consideration.

[1] rust-lang/rust#85379
[2] hyperium/tonic#966

@hexfusion hexfusion added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Apr 9, 2022
@Darksonn Darksonn added the M-net Module: tokio/net label Apr 10, 2022
@Darksonn
Copy link
Contributor

Hmm, this might need to be added to mio first. That said, you can already do this today before support is added to Tokio by using Tokio's from_std function.

@gustav3d
Copy link

Sure, it can be done by using an unstable feature, forcing you into nighty :(

The problem is that there is no progression to get rust-lang/rust#85410 into FCP state.
I posted an FCP progression question at the issue recently, also offering my - help if possible. but no response, so removed it after a few days.
This seem to be a low interest feuture, i can understand that. But its still a nice to have thing :)

@Darksonn
Copy link
Contributor

If nothing else works, it is still possible to create the socket yourself using manual libc calls (possibly via nix) and converting it into a Tokio socket.

@Darksonn
Copy link
Contributor

I'm not sure what UDS crate you're referring to, and whatever it is, it isn't what I suggested.

@gustav3d
Copy link

gustav3d commented May 15, 2022 via email

@cathay4t
Copy link

The rust lang SocketAddr::from_abstract_name() became stable on 1.70.0. Support this might bump tokio's minimum rust version.

@Darksonn
Copy link
Contributor

It looks like it is available in mio on older rustc versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net
Projects
None yet
Development

No branches or pull requests

4 participants