Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waker update condition in CancellationTokenState::check_for_cancellation #4497

Merged
merged 1 commit into from Feb 14, 2022
Merged

Fix waker update condition in CancellationTokenState::check_for_cancellation #4497

merged 1 commit into from Feb 14, 2022

Conversation

b-naber
Copy link
Contributor

@b-naber b-naber commented Feb 13, 2022

There was a missing exclamation mark in the condition we used to test whether we need a waker update in check_for_cancellation.

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Feb 13, 2022
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync labels Feb 14, 2022
Darksonn
Darksonn approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@b-naber
Copy link
Contributor Author

b-naber commented Feb 14, 2022

@Darksonn Can you merge this?

@hawkw hawkw merged commit 9a3ce91 into tokio-rs:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-sync Module: tokio/sync R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-naber @Darksonn @hawkw