Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimal mio requirement to 0.7.11 #4492

Merged
merged 1 commit into from Feb 12, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 12, 2022

Motivation

Update minimal mio requirement to 0.7.11 includes tokio-rs/mio#1478 (needed for windows) and tokio-rs/mio#1434 (needed for macos).

Caught in #4490 (comment) by using taiki-e/cargo-minimal-versions#4.

info: running `cargo check --all-features` on tokio-stream (1/1)
   Compiling libc v0.2.69
   Compiling log v0.4.8
   Compiling autocfg v1.0.0
   Compiling memchr v2.2.0
    Checking cfg-if v0.1.2
    Checking arc-swap v0.4.0
    Checking pin-project-lite v0.2.5
    Checking once_cell v1.5.2
    Checking bytes v1.0.0
    Checking futures-core v0.3.0
    Checking futures-sink v0.3.0
   Compiling tokio v1.8.0
    Checking signal-hook-registry v1.1.1
    Checking mio v0.7.6
error[E0425]: cannot find value `TCP_KEEPINTVL` in crate `libc`
    --> /Users/taiki/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.6/src/sys/unix/tcp.rs:334:15
     |
334  |         libc::TCP_KEEPINTVL,
     |               ^^^^^^^^^^^^^ help: a constant with a similar name exists: `TCP_KEEPALIVE`
     |
    ::: /Users/taiki/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.69/src/unix/bsd/apple/mod.rs:2259:1
     |
2259 | pub const TCP_KEEPALIVE: ::c_int = 0x10;
     | ---------------------------------------- similarly named constant `TCP_KEEPALIVE` defined here

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Darksonn Darksonn merged commit 62274b0 into master Feb 12, 2022
@Darksonn Darksonn deleted the taiki-e/minimal-versions branch February 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants