tokio: add riscv32 to non atomic64 architectures #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-giersch
pushed a commit
to oliver-giersch/tokio
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempting to build a tokio based project for the
riscv32target architecture results in a compilation failure, due to lack ofAtomicU64. The macro that checks this condition is based on a static list of architectures. Theriscv32architecture is not included in this check, so it defaults tostdsupport forAtomicU64, which is incorrect.riscv32does not have 64-bit atomics.Solution
This PR simply adds
riscv32to the list of known architectures which do not have nativeAtomicU64. I've verified locally that projects build after this change.