sync: add more oneshot examples #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
T-docs
cgwalters
approved these changes
Oct 5, 2021
Noah-Kennedy
approved these changes
Oct 8, 2021
oliver-giersch
pushed a commit
to oliver-giersch/tokio
that referenced
this pull request
Oct 28, 2021
lithp
reviewed
Jan 10, 2023
| /// ``` | ||
| /// | ||
| /// To use a `Sender` from a destructor, put it in an [`Option`] and call | ||
| /// [`Option::take`]. |
There was a problem hiding this comment.
Can I ask why it's recommended to wrap Sender in an Option here? I can't seem to find a rationale!
There was a problem hiding this comment.
If you try removing the option, it should quickly become clear: it wont compile without it. Calling send on an oneshot channel destroys the sender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples are duplicated both on the module and
SenderorReceiverstructs to make them more easily discoverable.