Fix clippy warnings #4017
Merged
Fix clippy warnings #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Aug 2, 2021
|
The clippy setup doesn't find all the warnings because we fix clippy to a specific Rust version. This is because otherwise PRs randomly fail due unrelated clippy errors whenever new lints are added. We are always happy to fix clippy errors from newer versions of clippy. |
|
@Darksonn Thanks, but why did the build job fail? |
|
The CI failure will be fixed in #4020. You can either wait for that to be merged, or rebase this PR on an earlier commit in the master branch (e.g. |
|
The PR has been merged. |
Fix the clippy warning `needless_borrow`: https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Fix the clippy warning `bool_assert_comparison`: https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
@Darksonn Thanks for the notification 😄. |
Darksonn
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To improve the code quality, the clippy warnings were fixed.
Solution
Fix the clippy warnings. Also, prevent futures warnings to be merged by add the option
-D warningsto the build job.Fixes #3585.