Fix case where cancelled future would be leaked and add a regression … #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diggsey
force-pushed
the
db-fix-leaked-future
branch
2 times, most recently
from
e67de44
to
6e79a80
Compare
…test. Add panic-on-drop tests for JoinHandle::abort.
Diggsey
force-pushed
the
db-fix-leaked-future
branch
from
e0e4dbb
to
7d42950
Compare
Darksonn
added
A-tokio
Darksonn
approved these changes
Jul 18, 2021
sthagen
added a commit
to sthagen/tokio-rs-tokio
that referenced
this pull request
Jul 19, 2021
runtime: drop future when polling cancelled future (tokio-rs#3965)
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
carllerche
pushed a commit
that referenced
this pull request
Jul 19, 2021
zonyitoo
added a commit
to shadowsocks/shadowsocks-rust
that referenced
this pull request
Jul 20, 2021
database64128
pushed a commit
to Shadowsocks-NET/shadowsocks-rs
that referenced
this pull request
Jul 21, 2021
ref tokio-rs/tokio#3965 (cherry picked from commit 2c71e20)
atkdef
pushed a commit
to atkdef/shadowsocks-rust
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…test.
Fixes #3964
I have no idea if this is the correct fix as I don't really understand the design behind this code. EIther way, the comment here "The future has already been dropped" seems to be inaccurate.edit:
Updated based on feedback from @Darksonn - pretty sure this is the correct fix now.