Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: fix watch borrow_and_update #3913

Merged
merged 1 commit into from Jul 2, 2021
Merged

sync: fix watch borrow_and_update #3913

merged 1 commit into from Jul 2, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jul 2, 2021

This fixes a bug where borrow_and_update incorrectly sets the version when called after closing the channel.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jul 2, 2021
This was referenced Jul 2, 2021
Merged
Merged
carllerche
carllerche approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 should this be backported?

Edit: I see it didn't get released yet.

@carllerche carllerche merged commit c8ecfc8 into master Jul 2, 2021
@carllerche carllerche deleted the fix-watch branch July 2, 2021 17:14
@Darksonn Darksonn mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darksonn @carllerche