Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with tracing #3906

Merged
merged 1 commit into from Jun 30, 2021
Merged

Test with tracing #3906

merged 1 commit into from Jun 30, 2021

Conversation

Darksonn
Copy link
Contributor

We currently don't run any tests with tracing enabled.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio labels Jun 30, 2021
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the goal here is just to ensure that the tests pass with the "tracing" feature flag enabled, rather than to actually collect tracing output from these tests? If we wanted to collect output for debugging the tests, we would also need to add a tracing-subscriber dev-dependency and set up a subscriber in the tests to collect the emitted traces.

This looks good, though, if the goal is just to ensure the feature doesn't break stuff!

@Darksonn
Copy link
Contributor Author

I just wanted the tests to run. For example, there's a test that the header is not too large which we didn't run at all with the extra tracing id.

@carllerche
Copy link
Member

Very good, thanks

@carllerche carllerche merged commit 90e1935 into master Jun 30, 2021
@carllerche carllerche deleted the actually-test-tracing branch June 30, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants