Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read/try methods to NamedPipeServer #3899

Merged
merged 1 commit into from Jun 29, 2021
Merged

Add read/try methods to NamedPipeServer #3899

merged 1 commit into from Jun 29, 2021

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Jun 28, 2021 •
edited

Motivation

#3866 added various methods to the NamedPipeClient, but to keep the PR small, didn't for NamedPipeServer, so this is just the follow up PR to #3866 to add those same methods to NamedPipeServer.

Solution

Adds the same methods to NamedPipeServer as were added to NamedPipeClient in #3866.

@davidpdrsn davidpdrsn requested a review from udoprog June 28, 2021 14:44
@davidpdrsn davidpdrsn added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Jun 28, 2021
@Jake-Shadle Jake-Shadle mentioned this pull request Jun 28, 2021
Open
26 tasks
Darksonn
Darksonn approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me. Thanks for doing this!

udoprog
udoprog approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@udoprog udoprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Cheers!

@Darksonn Darksonn merged commit 57c90c9 into tokio-rs:master Jun 29, 2021
@Jake-Shadle Jake-Shadle deleted the pipeserver branch June 29, 2021 08:31
@Darksonn Darksonn mentioned this pull request Jul 2, 2021
Merged
@migrax migrax mentioned this pull request Jul 6, 2021
Closed
@softdevca softdevca mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog approved these changes

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jake-Shadle @udoprog @Darksonn @davidpdrsn