Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: emit waker op as str instead as Debug #3853

Merged
merged 1 commit into from Jun 14, 2021
Merged

tracing: emit waker op as str instead as Debug #3853

merged 1 commit into from Jun 14, 2021

Conversation

seanmonstar
Copy link
Member

It was an mistake to emit the op as a dyn Debug, it should be emitted as a string directly.

@seanmonstar seanmonstar requested a review from hawkw June 11, 2021 22:57
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio labels Jun 12, 2021
@seanmonstar seanmonstar merged commit f55b77a into master Jun 14, 2021
@seanmonstar seanmonstar deleted the tracing-wakers-op-as-str branch June 14, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@tobz tobz tobz approved these changes

@Darksonn Darksonn Darksonn approved these changes

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seanmonstar @carllerche @tobz @Darksonn @hawkw