Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable test_socket_pair on FreeBSD #3844

Merged
merged 1 commit into from Jun 14, 2021

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Jun 6, 2021

It was disabled due to an OS bug that has been fixed on all currently
supported releases of FreeBSD

Motivation

To increase test coverage

Solution

To reenable a test that no longer needs to be disabled

It was disabled due to an OS bug that has been fixed on all currently
supported releases of FreeBSD
@Darksonn Darksonn added A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate labels Jun 6, 2021
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@carllerche carllerche merged commit 2c24a02 into tokio-rs:master Jun 14, 2021
@asomers asomers deleted the pr176419-revert branch June 14, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants