Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Export sync::notify::Notified publicly. #3840

Merged
merged 2 commits into from Jun 14, 2021
Merged

feat: Export sync::notify::Notified publicly. #3840

merged 2 commits into from Jun 14, 2021

Conversation

yotamofek
Copy link
Contributor

Motivation

This is my attempt to get #3372 in, so addressed the comment there and opened this PR.
Quoting that PR:

I would like to avoid boxing the Notified future when storing it a struct in fede1024/rust-rdkafka#320 .

Solution

Add sync::futures module which exposes sync::notify::Notified.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jun 5, 2021
Darksonn
Darksonn reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a separate file here.

tokio/src/sync/mod.rs Outdated Show resolved Hide resolved
tokio/src/sync/futures.rs Outdated
@@ -0,0 +1,3 @@
//! Sync future types.

pub use super::notify::Notified;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the documentation for the Notified type look?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Like this. (Fixed the link in the last commit)

@carllerche
Copy link
Member

👍

Darksonn
Darksonn approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 21de476 into tokio-rs:master Jun 14, 2021
@Darksonn Darksonn mentioned this pull request Jun 15, 2021
Merged
@taiki-e taiki-e mentioned this pull request Jul 6, 2021
Merged
@Darksonn Darksonn mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yotamofek @carllerche @Darksonn