Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Tokio v1.5.0 #3695

Merged
merged 4 commits into from Apr 12, 2021
Merged

Prepare Tokio v1.5.0 #3695

merged 4 commits into from Apr 12, 2021

Conversation

Darksonn
Copy link
Contributor

1.5.0 (April 12, 2021)

Added

Fixed

Documented

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Apr 12, 2021
@carllerche
Copy link
Member

As a minor bikeshed point (belated) re: RwLock::new_with_max_reads, we don't really have any public new_with fns and std seems to only have ::with_ (e.g. Vec::with_capacity).

So, my vote would be: RwLock::with_max_readers instead of reads as the RwLock can have more than that total reads :)

Anyway, this isn't a hard block, we can always rename later w/ a deprecation process.

@Darksonn
Copy link
Contributor Author

Good point. I just renamed it here.

@Darksonn Darksonn mentioned this pull request Apr 12, 2021
@Darksonn Darksonn merged commit a5ee2f0 into master Apr 12, 2021
@Darksonn Darksonn deleted the prepare-1.5.0 branch April 12, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants