Require Park::Error: Debug for better panic messages. #3641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are seeing a few "failed to park" panics in the wild. The panic messages are very unhelpful as they don't contain information about the underlying error.
Solution
Add a
fmt::Debug
constraint toPark::Error
. This trait is internal and all implementors already satisfy it. Then we can useexpect()
on the result ofpark()
directly.