Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy -- -D warnings ? #3585

Closed
cssivision opened this issue Mar 6, 2021 · 3 comments · Fixed by #4017
Closed

fix clippy -- -D warnings ? #3585

cssivision opened this issue Mar 6, 2021 · 3 comments · Fixed by #4017
Labels
A-ci Area: The continuous integration setup C-feature-request Category: A feature request.

Comments

@cssivision
Copy link
Contributor

cssivision commented Mar 6, 2021 •
edited

when run cargo clippy -- -D warnings, errors occur.

maybe we can fix it, and this rule to ci.yaml.
@cssivision cssivision added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Mar 6, 2021
@taiki-e
Copy link
Member

taiki-e commented Mar 6, 2021

I think this is due to we use old clippy #2962
The latest clippy supports MSRV configurations, but there is still the issue that clippy adds new lints with each new release, blocking irrelevant PR.

@Darksonn Darksonn added A-ci Area: The continuous integration setup and removed A-tokio Area: The main tokio crate labels Mar 6, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Mar 6, 2021

Feel free to submit PRs that fix clippy warnings in newer versions of clippy than the one we are using.

@cssivision cssivision mentioned this issue Mar 7, 2021
Merged
@cssivision cssivision reopened this Mar 10, 2021
@LinkTed LinkTed mentioned this issue Aug 2, 2021
Merged
@taiki-e taiki-e closed this as completed Aug 2, 2021
@taiki-e
Copy link
Member

taiki-e commented Aug 2, 2021

-D warnings is not needed. We have already denied warnings (via RUSTFLAGS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ci Area: The continuous integration setup C-feature-request Category: A feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clippy warnings
3 participants
@Darksonn @cssivision @taiki-e