Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress deprecated warnings for spin_loop_hint #3497

Merged
merged 4 commits into from Feb 1, 2021
Merged

Suppress deprecated warnings for spin_loop_hint #3497

merged 4 commits into from Feb 1, 2021

Conversation

vorot93
Copy link
Member

@vorot93 vorot93 commented Feb 1, 2021

Replaces #3496 as that's ahead of its time due to MSRV policy.

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Feb 1, 2021
taiki-e
taiki-e reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding todo comments.

tokio/src/loom/std/mod.rs Show resolved Hide resolved
tokio/src/sync/task/atomic_waker.rs Show resolved Hide resolved
@vorot93 vorot93 mentioned this pull request Feb 1, 2021
Closed
vorot93 and others added 2 commits February 1, 2021 14:36
@vorot93 @taiki-e
Update tokio/src/loom/std/mod.rs
3788d26 
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@vorot93 @taiki-e
Update tokio/src/sync/task/atomic_waker.rs
1ddd57e 
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@vorot93 vorot93 merged commit cc97fb8 into master Feb 1, 2021
@vorot93 vorot93 deleted the vorot93/allow-deprecated-spin-loop-hint branch February 1, 2021 12:55
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vorot93 @Darksonn @taiki-e