util: add ReusableBoxFuture utility #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the tests can't run with miri because of missing support for polling future trait objects. See rust-lang/miri#1038. |
vitalyd
reviewed
Jan 23, 2021
vitalyd
reviewed
Jan 23, 2021
vitalyd
reviewed
Jan 23, 2021
vitalyd
reviewed
Jan 23, 2021
vitalyd
reviewed
Jan 23, 2021
|
JM2C: this doesn't belong in sync mod. |
|
I was not sure which module to put it in. What do you suggest? |
|
Though it feels useful enough for a crate of its own, maybe just a root item. ( |
hyyking
reviewed
Jan 24, 2021
| { | ||
| let boxed: Box<dyn Future<Output = T> + Send> = Box::new(future); | ||
|
|
||
| let boxed = Box::into_raw(boxed); |
There was a problem hiding this comment.
Suggested change
| let boxed = Box::into_raw(boxed); | |
| let boxed = NonNull::from(Box::leak(boxed)); |
Removes the unnecessary unsafe code bellow
This was referenced Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found myself wanting a utility like this a few times, and inspired by #3463, I have now written it.
One question is which module it should go in. I put it in
tokio_util::sync, but I'm not sure this is the best place.Discussed here.