Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: use #[non_exhaustive] instead of private unit field (#3320)" #3323

Merged
merged 1 commit into from Dec 23, 2020
Merged

Revert "chore: use #[non_exhaustive] instead of private unit field (#3320)" #3323

merged 1 commit into from Dec 23, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 23, 2020 •
edited

This reverts commit 575938d. (#3320)

Motivation

For context, see discussion in discord.

Solution

carllerche
carllerche approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I can look at the PR after 1.0. I have not yet concidered #[non_exhaustive] used like this and would want to better understand it.

@carllerche carllerche merged commit ce0e9c6 into tokio-rs:master Dec 23, 2020
@taiki-e taiki-e deleted the revert-3320 branch December 23, 2020 16:44
@taiki-e
Copy link
Member Author

taiki-e commented Jun 26, 2021

FYI: rust-lang/rust#86592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@Darksonn Darksonn Awaiting requested review from Darksonn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taiki-e @carllerche