Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename with_io to try_io and drop with_poll #3306

Merged
merged 6 commits into from Dec 21, 2020
Merged

Rename with_io to try_io and drop with_poll #3306

merged 6 commits into from Dec 21, 2020

Conversation

Darksonn
Copy link
Contributor

Follow-up to #3304.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Dec 21, 2020
@Darksonn Darksonn added this to the v1.0 milestone Dec 21, 2020
carllerche
carllerche requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor request.

tokio/src/io/async_fd.rs Outdated Show resolved Hide resolved
carllerche
carllerche approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks.

@carllerche carllerche merged commit 564c943 into master Dec 21, 2020
@carllerche carllerche deleted the async-fd-try-io branch December 21, 2020 23:42
@kiron1 kiron1 mentioned this pull request Dec 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@bdonlan bdonlan Awaiting requested review from bdonlan

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Darksonn @carllerche