Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _mut variants of methods on AsyncFd #3304

Merged
merged 6 commits into from Dec 21, 2020
Merged

Add _mut variants of methods on AsyncFd #3304

merged 6 commits into from Dec 21, 2020

Conversation

bIgBV
Copy link
Contributor

@bIgBV bIgBV commented Dec 21, 2020 •
edited

Motivation

Solution

  • Update AsyncFdReadGuard::with_poll to pass a reference to the underlying
    object to the clousure.
  • Create a new AsyncFdReadMutGuard to provide mutable APIs on the underlying
    object.

Bhargav Voleti and others added 3 commits December 20, 2020 20:49
Update AsyncFd's public APIs
471fa2c 
* Update `AsyncFdReadGuard::with_poll` to pass a reference to the underlying
  object to the clousure.
* Create a new `AsyncFdReadMutGuard` to provide mutable APIs on the underlying
  object.
@Darksonn
Add _mut methods to AsyncFd and fix docs
79ddd95
@Darksonn
Fix guard signatures
01c9ece
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Dec 21, 2020
@Darksonn Darksonn changed the title [WIP] Update AsyncFd's public APIs Add _mut variants of methods on AsyncFd Dec 21, 2020
@Darksonn
Copy link
Contributor

Changing with_io to return Poll will happen in a follow-up PR.

@carllerche carllerche added this to the v1.0 milestone Dec 21, 2020
carllerche
carllerche approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks both of you 👍

@Darksonn Darksonn merged commit c7671a0 into tokio-rs:master Dec 21, 2020
This was referenced Dec 21, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@bdonlan bdonlan Awaiting requested review from bdonlan

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bIgBV @Darksonn @carllerche