Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prelude #3299

Merged
merged 2 commits into from Dec 19, 2020
Merged

Remove prelude #3299

merged 2 commits into from Dec 19, 2020

Conversation

Darksonn
Copy link
Contributor

Closes: #3257

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Dec 19, 2020
@Darksonn Darksonn added this to the v1.0 milestone Dec 19, 2020
carllerche
carllerche approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks !

@carllerche carllerche merged commit 78f2340 into master Dec 19, 2020
@carllerche carllerche deleted the remove-prelude branch December 19, 2020 19:42
@daprilik daprilik mentioned this pull request Jan 5, 2021
Merged
@RoadTrain RoadTrain mentioned this pull request Apr 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

tokio: consider removing prelude
2 participants
@Darksonn @carllerche