time: remove Box from Sleep
#3278
Merged
+104
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the box from `Sleep`, taking advantage of intrusive wakers. The `Sleep` future is now `!Unpin`. Closes #3267
bdonlan
reviewed
Dec 16, 2020
| @@ -317,15 +317,15 @@ async fn drop_after_reschedule_at_new_scheduled_time() { | |||
|
|
|||
There was a problem hiding this comment.
We should have a test that asserts that Sleep is !Unpin (same for other types that contain pinned Sleeps).
There was a problem hiding this comment.
Such a test can easily be constructed using the macros in tokio/tokio/tests/async_send_sync.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the box from
Sleep, taking advantage of intrusive wakers. TheSleepfuture is now!Unpin.Intervalboxes theSleepinternally. The box is reused across polls which amortized the allocation. It makes the type a bit easier to use. Implementing an allocation-freeIntervalis fairly trivial usingasync-streamand callingsleep().Most of the PR is updating code to handle
!Unpinsleep.Closes #3267