tracing: switch to unstable for 1.0. #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling `tracing` integration now requires compiling with `--cfg tokio_unstable`. Once `tracing-core` guarantees the same level of stability as Tokio 1.0, unstable can be removed. Closes #3258
Darksonn
added
A-tokio
|
You should also update |
|
Done! |
Darksonn
approved these changes
Dec 14, 2020
Co-authored-by: Alice Ryhl <alice@ryhl.io>
hawkw
approved these changes
Dec 14, 2020
hawkw
reviewed
Dec 14, 2020
| @@ -102,6 +102,9 @@ mio = { version = "0.7.6", optional = true } | |||
| num_cpus = { version = "1.8.0", optional = true } | |||
| parking_lot = { version = "0.11.0", optional = true } | |||
| slab = { version = "0.4.1", optional = true } | |||
|
|
|||
| # Currently unstable. The version of tracing-core may be changed at any time. | |||
| # Requires `--cfg tokio_unstable` to enable in Tokio. | |||
| tracing = { version = "0.1.21", default-features = false, features = ["std"], optional = true } # Not in full | |||
There was a problem hiding this comment.
might be worth moviung this to [target.'cfg(tokio_unstable)'.dependencies] so it's not downloaded when the cfg isn't set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
tracingintegration now requires compiling with--cfg tokio_unstable. Oncetracing-coreguarantees the same level ofstability as Tokio 1.0, unstable can be removed.
Closes #3258