Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: add UnixStream readiness and non-blocking ops #3246

Merged
merged 8 commits into from Dec 13, 2020
Merged

net: add UnixStream readiness and non-blocking ops #3246

merged 8 commits into from Dec 13, 2020

Conversation

cssivision
Copy link
Contributor

Refs: #2968

@Darksonn Darksonn mentioned this pull request Dec 10, 2020
Closed
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net labels Dec 10, 2020
Darksonn
Darksonn reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor doc things that I assume originate from the TcpStream PR.

tokio/src/net/unix/stream.rs Outdated Show resolved Hide resolved
tokio/src/net/unix/stream.rs Outdated Show resolved Hide resolved
tokio/src/net/unix/stream.rs Outdated Show resolved Hide resolved
tokio/src/net/unix/stream.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn mentioned this pull request Dec 10, 2020
Closed
@Darksonn
Copy link
Contributor

Can you add poll_read_ready and poll_write_ready too?

cssivision and others added 3 commits December 10, 2020 23:47
@cssivision @Darksonn
Update tokio/src/net/unix/stream.rs
776f2bb 
Co-authored-by: Alice Ryhl <alice@ryhl.io>
@cssivision @Darksonn
Update tokio/src/net/unix/stream.rs
be8c522 
Co-authored-by: Alice Ryhl <alice@ryhl.io>
@cssivision @Darksonn
Update tokio/src/net/unix/stream.rs
e3f2381 
Co-authored-by: Alice Ryhl <alice@ryhl.io>
@cssivision
Copy link
Contributor Author

Can you add poll_read_ready and poll_write_ready too?

I'm glad to.

Darksonn
Darksonn approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tokio/src/net/unix/stream.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn merged commit 4c55419 into tokio-rs:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cssivision @Darksonn