Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: add missing feature flags for docs.rs on 0.2.x #3236

Merged
merged 3 commits into from Dec 10, 2020
Merged

task: add missing feature flags for docs.rs on 0.2.x #3236

merged 3 commits into from Dec 10, 2020

Conversation

nylonicious
Copy link
Contributor

Fixes #3206 on 0.2.x branch.

@nylonicious nylonicious changed the title task: add missing feature flags for docs.rs task: add missing feature flags for docs.rs on 0.2.x Dec 8, 2020
@Darksonn Darksonn added A-tokio Area: The main tokio crate T-v0.2.x Topic: tokio 0.2.x labels Dec 9, 2020
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a quick test to double-check this, but they actually also require the rt-core feature.

@@ -31,6 +31,7 @@ use std::{fmt, thread};
///
/// [`tokio::task::LocalKey`]: struct@crate::task::LocalKey
#[macro_export]
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "rt-util", "rt-core"))))]

@@ -90,6 +91,7 @@ macro_rules! __task_local_inner {
/// # }
/// ```
/// [`std::thread::LocalKey`]: struct@std::thread::LocalKey
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))]
#[cfg_attr(docsrs, doc(cfg(all(feature = "rt-util", "rt-core"))))]

@Darksonn Darksonn added the M-task Module: tokio/task label Dec 9, 2020
@nylonicious
Copy link
Contributor Author

Sorry, my bad I paid more attention to 0.3 version. Should be fine now I think.

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Darksonn Darksonn merged commit dccc58a into tokio-rs:v0.2.x Dec 10, 2020
@nylonicious nylonicious deleted the doc-missing-flags-0.2.x branch January 10, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task T-v0.2.x Topic: tokio 0.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants