New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: add missing feature flags for docs.rs on 0.2.x #3236
task: add missing feature flags for docs.rs on 0.2.x #3236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a quick test to double-check this, but they actually also require the rt-core
feature.
tokio/src/task/task_local.rs
Outdated
@@ -31,6 +31,7 @@ use std::{fmt, thread}; | |||
/// | |||
/// [`tokio::task::LocalKey`]: struct@crate::task::LocalKey | |||
#[macro_export] | |||
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))] | |
#[cfg_attr(docsrs, doc(cfg(all(feature = "rt-util", "rt-core"))))] |
tokio/src/task/task_local.rs
Outdated
@@ -90,6 +91,7 @@ macro_rules! __task_local_inner { | |||
/// # } | |||
/// ``` | |||
/// [`std::thread::LocalKey`]: struct@std::thread::LocalKey | |||
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[cfg_attr(docsrs, doc(cfg(feature = "rt-util")))] | |
#[cfg_attr(docsrs, doc(cfg(all(feature = "rt-util", "rt-core"))))] |
Sorry, my bad I paid more attention to 0.3 version. Should be fine now I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #3206 on
0.2.x
branch.