Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: expose poll_* methods on UnixDatagram #3223

Merged
merged 3 commits into from Dec 10, 2020
Merged

net: expose poll_* methods on UnixDatagram #3223

merged 3 commits into from Dec 10, 2020

Conversation

cssivision
Copy link
Contributor

@cssivision cssivision commented Dec 7, 2020 •
edited by Darksonn

Closes: #2853
Refs: #2968

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net labels Dec 7, 2020
@Darksonn
Copy link
Contributor

Darksonn commented Dec 7, 2020

Thanks! The relevant PR of the same thing for UdpSocket is #2981, and it seems you are missing some of the functions. We also want to eventually add the methods from #3138 to UnixDatagram as well, although it doesn't have to be in this PR.

@cssivision
Copy link
Contributor Author

I will fire another PR to add the other missing functions.

@Darksonn
Copy link
Contributor

Darksonn commented Dec 7, 2020

I would prefer if the other poll_* functions are added in this one, although I don't mind regarding the ones from #3138.

@cssivision
Copy link
Contributor Author

ok, I will add in this PR.

@cssivision
Copy link
Contributor Author

ping

Darksonn
Darksonn approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! It looks good, and the tests are nice.

tokio/src/net/unix/datagram/socket.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn merged commit 2a30e13 into tokio-rs:master Dec 10, 2020
@Darksonn Darksonn mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose poll_* methods on UnixDatagram
2 participants
@cssivision @Darksonn