sync: fix mpsc bug related to closing the channel #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing a channel, it is possible to get into an invalid state when outstanding permits release capacity back to the channel.
carllerche
force-pushed
the
fix-0.2-chan-bug
branch
from
4932e35
to
19a6d14
Compare
LucioFranco
approved these changes
Dec 7, 2020
hawkw
approved these changes
Dec 7, 2020
| @@ -512,3 +512,27 @@ fn ready_close_cancel_bounded() { | |||
|
|
|||
| assert!(recv.is_woken()); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn permit_available_not_acquired_close() { | |||
There was a problem hiding this comment.
nit: it might be nice to have a comment here explaining what this test reproduces?
carllerche
added a commit
that referenced
this pull request
Dec 7, 2020
Forward ports the test included in #3215. The mpsc sempahore has been replaced in 0.3 and does not include the bug being fixed.
carllerche
added a commit
that referenced
this pull request
Dec 7, 2020
Forward ports the test included in #3215. The mpsc sempahore has been replaced in 0.3 and does not include the bug being fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/lukesteensen/tokio-channel-repro