New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add futures executor threadpool #3198
Merged
Darksonn
merged 11 commits into
tokio-rs:master
from
carlosb1:2774_add_futures_executor_threadpool
Dec 22, 2020
Merged
examples: add futures executor threadpool #3198
Darksonn
merged 11 commits into
tokio-rs:master
from
carlosb1:2774_add_futures_executor_threadpool
Dec 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
Area: The main tokio crate
C-maintenance
Category: PRs that clean code up or issues documenting cleanup.
M-runtime
Module: tokio/runtime
labels
Dec 6, 2020
Darksonn
reviewed
Dec 17, 2020
Darksonn
reviewed
Dec 17, 2020
examples/custom-executor.rs
Outdated
Comment on lines
39
to
41
// Spawn tokio runtime on a single background thread | ||
// enabling IO and timers. | ||
let rt = tokio::runtime::Builder::new_current_thread() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be a new_multi_thread
with one worker thread if we want a background thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!, sorry I didn't see it
Darksonn
reviewed
Dec 17, 2020
Co-authored-by: Alice Ryhl <alice@ryhl.io>
…losb1/tokio into 2774_add_futures_executor_threadpool
Darksonn
approved these changes
Dec 19, 2020
Darksonn
reviewed
Dec 19, 2020
Darksonn
changed the title
2774 add futures executor threadpool
examples: add futures executor threadpool
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-tokio
Area: The main tokio crate
C-maintenance
Category: PRs that clean code up or issues documenting cleanup.
M-runtime
Module: tokio/runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2774