Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 removed tokio::io::Registration, breaking dbus-tokio crate #3040

Closed
diwic opened this issue Oct 25, 2020 · 2 comments
Closed

0.3 removed tokio::io::Registration, breaking dbus-tokio crate #3040

diwic opened this issue Oct 25, 2020 · 2 comments
Labels
A-tokio Area: The main tokio crate C-question User questions that are neither feature requests nor bug reports M-io Module: tokio/io

Comments

@diwic
Copy link

diwic commented Oct 25, 2020

Hi,

It looks like all possibilities to add a custom fd have been removed with Tokio 0.3, or possibly it has been moved to somewhere I can't find it. In Tokio 0.2 we used tokio::io::Registration for this purpose.

This is a fundamental feature for the dbus-tokio crate, so at this point we can't upgrade to 0.3. The code is also something that has been tested and patched by several community members as we had some hard time removing race conditions etc, so if the logic has been significantly changed, we need to start that process over from scratch.
The somewhat hairy code is here in case you want a look at it: https://github.com/diwic/dbus-rs/blob/master/dbus-tokio/src/connection.rs

@diwic diwic added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Oct 25, 2020
@Darksonn
Copy link
Contributor

This is due to the removal of mio from the public API of Tokio. The next release will contain a type called AsyncFd, which was merged with #2903, however it has not been released yet.

@Darksonn Darksonn added C-question User questions that are neither feature requests nor bug reports M-io Module: tokio/io and removed C-bug Category: This is a bug. labels Oct 25, 2020
@carllerche
Copy link
Member

Fixed by #2903.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-question User questions that are neither feature requests nor bug reports M-io Module: tokio/io
Projects
None yet
Development

No branches or pull requests

3 participants