Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change recv and recv_from to use ReadBuf on UdpSocket and UnixDatagram #2988

Closed
Darksonn opened this issue Oct 19, 2020 · 1 comment
Closed

Change recv and recv_from to use ReadBuf on UdpSocket and UnixDatagram #2988

Darksonn opened this issue Oct 19, 2020 · 1 comment
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Milestone
v1.0

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Oct 19, 2020 •
edited

These methods on UdpSocket and UnixDatagram currently take a &mut [u8], but should be changed to take a ReadBuf.

This is a breaking change, and should be done as part of the transition to 1.0.
@Darksonn Darksonn added C-enhancement Category: A PR with an enhancement or bugfix. A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 19, 2020
@Darksonn Darksonn added this to the v1.0 milestone Oct 19, 2020
@Darksonn Darksonn changed the title Change UdpSocket::recv and recv_from to use ReadBuf Change recv and recv_from to use ReadBuf on UdpSocket and UnixDatagram Oct 19, 2020
@Darksonn
Copy link
Contributor Author

Closing as this should only be done for the poll_* variants, and those are currently not public. See #2981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@Darksonn