Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor runtime driver useage of Either and cfgs #2918

Merged
merged 2 commits into from Oct 12, 2020
Merged

chore: refactor runtime driver useage of Either and cfgs #2918

merged 2 commits into from Oct 12, 2020

Conversation

ipetkov
Copy link
Member

@ipetkov ipetkov commented Oct 6, 2020 •
edited

  • rt: optimize usage of either when creating a runtime::Driver
  • chore: fix unused warning for LinkedList::last on Windows

Fixes #2916

@ipetkov ipetkov added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate labels Oct 6, 2020
@Darksonn Darksonn added the M-runtime Module: tokio/runtime label Oct 6, 2020
@ipetkov ipetkov merged commit 24d0a0c into master Oct 12, 2020
@ipetkov ipetkov deleted the ivan/driver-either branch October 12, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-runtime Module: tokio/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: refactor runtime driver useage of Either
3 participants
@ipetkov @LucioFranco @Darksonn