Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update internal Mutex shim #2867

Closed
carllerche opened this issue Sep 23, 2020 · 0 comments · Fixed by #2872
Closed

chore: update internal Mutex shim #2867

carllerche opened this issue Sep 23, 2020 · 0 comments · Fixed by #2872
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-sync Module: tokio/sync
Milestone
v0.3

Comments

@carllerche
Copy link
Member

Internally, Tokio does not rely on mutex poisoning. We should update the Mutex shim to remove the poisoning aspect of the API. This can be done using LockResult::into_inner.

This has come up a few times in PR reviews (e.g. #2828 (comment)).
@carllerche carllerche added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate labels Sep 23, 2020
@carllerche carllerche added this to the v0.3 milestone Sep 23, 2020
@carllerche carllerche mentioned this issue Sep 23, 2020
Merged
@Darksonn Darksonn added the M-sync Module: tokio/sync label Sep 23, 2020
@zaharidichev zaharidichev mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-sync Module: tokio/sync
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

chore: handle std Mutex poisoning in a shim zaharidichev/tokio
2 participants
@carllerche @Darksonn