Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_mut() for Mutex & RwLock #2856

Merged
merged 1 commit into from Sep 23, 2020
Merged

Add get_mut() for Mutex & RwLock #2856

merged 1 commit into from Sep 23, 2020

Conversation

danielhenrymantilla
Copy link
Contributor

Motivation

  • Consistency with stdlib's API;

  • Useful to avoid unnecessary locking.

Solution

Add that API

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-sync Module: tokio/sync labels Sep 22, 2020
Darksonn
Darksonn approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@carllerche
Copy link
Member

Thanks!

@carllerche carllerche merged commit 0f70530 into tokio-rs:master Sep 23, 2020
@danielhenrymantilla danielhenrymantilla deleted the mutex-rwlock-get-mut branch September 24, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielhenrymantilla @carllerche @Darksonn