Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: rename Notify::notify() -> notify_one() #2822

Merged
merged 2 commits into from Sep 7, 2020
Merged

sync: rename Notify::notify() -> notify_one() #2822

merged 2 commits into from Sep 7, 2020

Conversation

alce
Copy link
Member

@alce alce commented Sep 7, 2020

closes #2813

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync labels Sep 7, 2020
Darksonn
Darksonn approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Darksonn Darksonn merged commit 38ec484 into tokio-rs:master Sep 7, 2020
@alce alce deleted the rename-notify branch September 7, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync: rename Notify::notify() -> notify_one()
2 participants
@alce @Darksonn