Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch channel breaking changes #2806

Merged
merged 3 commits into from Sep 2, 2020
Merged

Watch channel breaking changes #2806

merged 3 commits into from Sep 2, 2020

Conversation

blasrodri
Copy link
Contributor

Motivation

Fixes: #2172

Solution

  • rename broadcast() to send() for watch channel
  • watch channel .recv() returns T

carllerche
carllerche approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit 5a1a6dc into tokio-rs:master Sep 2, 2020
@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync labels Sep 2, 2020
@Darksonn Darksonn added this to the v0.3 milestone Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

sync: breaking changes to watch channel.
3 participants
@blasrodri @carllerche @Darksonn