Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent about threaded vs basic scheduler in v0.3 #2698

Closed
Darksonn opened this issue Jul 25, 2020 · 2 comments
Closed

Be consistent about threaded vs basic scheduler in v0.3 #2698

Darksonn opened this issue Jul 25, 2020 · 2 comments
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-runtime Module: tokio/runtime
Milestone
v0.3

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Jul 25, 2020 •
edited

Currently Runtime::new() and #[tokio::main] will make their choice about the kind of runtime by inspecting the rt-threaded flag. This should be changed in Tokio v0.3, and code uses #[tokio::main] without rt-threaded should probably error with a suggestion to enable the feature or to use the basic scheduler.

We should also overhaul the runtime builder.
@Darksonn Darksonn added C-bug Category: This is a bug. A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jul 25, 2020
@Darksonn Darksonn added this to the v0.3 milestone Jul 25, 2020
This was referenced Jul 25, 2020
Closed
Closed
Closed
@carllerche carllerche mentioned this issue Jul 30, 2020
Closed
6 tasks
@carllerche
Copy link
Member

Superseded by #2698

@benesch
Copy link
Contributor

benesch commented Aug 8, 2020

Superseded by #2698

#2698 is this very issue :D. For posterity, I believe the correct superseding issue is #2720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-runtime Module: tokio/runtime
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
3 participants
@carllerche @benesch @Darksonn